refactor(core): tighten feature-gated runtime facade#826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gcwing/mainand keep this PR as a single commit.bitfun-core/product-fullowner-crate propagation into the core feature graph instead of forcing ownerproduct-fullthrough dependency declarations.tool-packsandproduct-domainsoptional inbitfun-core; no-default core now keeps product runtime surfaces gated while retaining remote workspace identity helpers.Guardrails
bitfun-corewithfeatures = ["product-full"].default = ["product-full"]remains unchanged.Validation
node scripts/check-core-boundaries.mjscargo check -p bitfun-core --no-default-featurescargo check -p bitfun-core --features product-fullcargo check -p bitfun-acpcargo check -p bitfun-clicargo check -p bitfun-desktopcargo test -p bitfun-core --no-default-features --lib workspace_session_identity -- --nocapturecargo test -p bitfun-core core_product_domain_runtime_owner -- --nocapturecargo test -p bitfun-core core_service_agent_runtime_owner -- --nocapturecargo test -p bitfun-core remote_ -- --nocapturecargo test -p bitfun-services-integrations --features product-fullcargo test -p bitfun-product-domains --features product-fullcargo test -p bitfun-tool-packs --features product-fullrustfmt --edition 2021 --check --config skip_children=true ...git diff --check gcwing/main..HEADgit diff -- package.json scripts/dev.cjs scripts/desktop-tauri-build.mjs scripts/ensure-openssl-windows.mjs scripts/ci/setup-openssl-windows.ps1 BitFun-Installer